Skip to content

Add temp 302 redirect to all other paths than the root#748

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
mattbates:mb/switch-redirect-temp
Nov 4, 2021
Merged

Add temp 302 redirect to all other paths than the root#748
jetstack-bot merged 1 commit intocert-manager:masterfrom
mattbates:mb/switch-redirect-temp

Conversation

@mattbates
Copy link
Contributor

@mattbates mattbates commented Nov 4, 2021

Based on feedback from @munnerz, propose we do the following (for now):

  • Use a permanent (301) redirect for docs.cert-manager.io
  • Use a temporary (302) redirect for all other paths (which may or may not work currently)

We should follow-up to this PR with redirect rules for specific pages that we know are linked from other pages and feature prominently in search engine listings.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 4, 2021
@netlify
Copy link

netlify bot commented Nov 4, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 7d83d64

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6183e13678c1c100085e2a8d

😎 Browse the preview: https://deploy-preview-748--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 4, 2021

Hi @mattbates. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2021
SgtCoDFish
SgtCoDFish approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

From reading netlify docs this looks correct to me!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@SgtCoDFish
Copy link
Member

SgtCoDFish commented Nov 4, 2021

/ok-to-test

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2021
munnerz
munnerz approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattbates, munnerz, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@munnerz
Copy link
Member

munnerz commented Nov 4, 2021

Seems like Netlify dropped webhooks or something.. 🤔 you may want to git commit --amend && git push -f origin head (where 'origin' is the name of your mattbates remote/fork) to give it a kick

@mattbates
Add temp 302 redirect to all other paths than the root
7d83d64 
Signed-off-by: Matthew Bates <mattbates25@gmail.com>
@mattbates mattbates force-pushed the mb/switch-redirect-temp branch from e096999 to 7d83d64 Compare November 4, 2021 13:33
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@chance19
Copy link
Contributor

chance19 commented Nov 4, 2021

@mattbates to your point re:

We should follow-up to this PR with redirect rules for specific pages that we know are linked from other pages and feature prominently in search engine listings.

I started work on this with #747

@SgtCoDFish
Copy link
Member

SgtCoDFish commented Nov 4, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@jetstack-bot jetstack-bot merged commit 4344ac5 into cert-manager:master Nov 4, 2021
@jetstack-bot jetstack-bot mentioned this pull request Dec 3, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munnerz munnerz munnerz approved these changes

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattbates @jetstack-bot @SgtCoDFish @munnerz @chance19